[webkit-reviews] review granted: [Bug 66814] [chromium] Renderer crashes when about:gpucrash is loaded : [Attachment 104934] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 17:15:12 PDT 2011


James Robinson <jamesr at chromium.org> has granted Iain Merrick
<husky at google.com>'s request for review:
Bug 66814: [chromium] Renderer crashes when about:gpucrash is loaded
https://bugs.webkit.org/show_bug.cgi?id=66814

Attachment 104934: Patch
https://bugs.webkit.org/attachment.cgi?id=104934&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Ah, I see.  Very subtle.  It seems like we've done something wrong with
setIsAcceleratedCompositingActive() if we need it do have side effects for
true->true transitions.  Maybe we need a separate notion of 'toggling
compositing on/off' vs 'please update yourself due to some compositing change'.
 That would be for a different patch, though.


More information about the webkit-reviews mailing list