[webkit-reviews] review denied: [Bug 66746] Expose setFullscreen method on WebPluginContainer : [Attachment 104792] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jeremy Apthorp
<jeremya at chromium.org>'s request for review:
Bug 66746: Expose setFullscreen method on WebPluginContainer
https://bugs.webkit.org/show_bug.cgi?id=66746

Attachment 104792: Patch
https://bugs.webkit.org/attachment.cgi?id=104792&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104792&action=review


> Source/WebKit/chromium/public/WebPluginContainer.h:93
> +    virtual void setFullscreen(bool) = 0;

Since this is implemented as webkitRequestFullScreen, it could fail.  In other
words, this method should probably have a name indicative of the fact that this

could fail.

Another idea here, is that we could just expose a requestFullScreen function on

WebElement.  WebPluginContainer provides a way to get the WebElement containing

the plugin.  We could also add a cancelFullScreen method on WebElement.  This
might be the better way to expose this functionality to the embedder of WebKit.