[webkit-reviews] review granted: [Bug 66244] Cached pages don't fully update when going back after changing the display scale factor : [Attachment 104923] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 66244: Cached pages don't fully update when going back after changing the
display scale factor
https://bugs.webkit.org/show_bug.cgi?id=66244

Attachment 104923: Patch
https://bugs.webkit.org/attachment.cgi?id=104923&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104923&action=review


Patch seems OK. Could be improved a bit.

> Source/WebCore/page/Frame.cpp:1068
> +    pageCache()->markPagesForFullStyleRecalc();

This will run a bit too often. It runs for the top level frame and then runs
again for each subframe. That means we’ll run through the page cache over and
over again. No need to do that.

Also, this does more work than needed as I mention below.

> Source/WebCore/page/Page.cpp:601
> +    pageCache()->markPagesForFullStyleRecalc();

This does more work than it has to. Items in the page cache might be for the
back/forward in other windows that have a different scale factor. It’s overkill
to do it on all the pages in the page cache. Instead we could iterate the
back/forward list and do it only for the history items found there.