[webkit-reviews] review denied: [Bug 66814] [chromium] Renderer crashes when about:gpucrash is loaded : [Attachment 104924] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 16:10:04 PDT 2011


James Robinson <jamesr at chromium.org> has denied Iain Merrick
<husky at google.com>'s request for review:
Bug 66814: [chromium] Renderer crashes when about:gpucrash is loaded
https://bugs.webkit.org/show_bug.cgi?id=66814

Attachment 104924: Patch
https://bugs.webkit.org/attachment.cgi?id=104924&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104924&action=review


> Source/WebKit/chromium/src/WebViewImpl.cpp:2667
> +    // Force ViewHostMsg_DidActivateAcceleratedCompositing to be sent so
> +    // that the browser process can reacquire surfaces.
> +    m_isAcceleratedCompositingActive = false;
> +    setIsAcceleratedCompositingActive(success);

why is this different from the previous logic?

looks like you broke page overlays here, any particular reason to change that
logic too?


More information about the webkit-reviews mailing list