[webkit-reviews] review granted: [Bug 66081] The "port" property of an <a> whose href does not specify a port returns the wrong value : [Attachment 104916] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 14:39:17 PDT 2011


Adam Barth <abarth at webkit.org> has granted Rachel Blum <groby at chromium.org>'s
request for review:
Bug 66081: The "port" property of an <a> whose href does not specify a port
returns the wrong value
https://bugs.webkit.org/show_bug.cgi?id=66081

Attachment 104916: Patch
https://bugs.webkit.org/attachment.cgi?id=104916&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104916&action=review


I feel like I get in trouble whenever I review these sorts of patches, but this
patch seems good.

> Source/WebCore/html/HTMLAnchorElement.cpp:409
> +    return String("");

You can just return "" or emptyString().


More information about the webkit-reviews mailing list