[webkit-reviews] review requested: [Bug 66571] Keep track of topCallFrame for Stack traces : [Attachment 104894] updated arm-ready patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 12:51:14 PDT 2011


Juan C. Montemayor <jmont at apple.com> has asked	for review:
Bug 66571: Keep track of topCallFrame for Stack traces
https://bugs.webkit.org/show_bug.cgi?id=66571

Attachment 104894: updated arm-ready patch
https://bugs.webkit.org/attachment.cgi?id=104894&action=review

------- Additional Comments from Juan C. Montemayor <jmont at apple.com>
I added the changes suggested by Geoff. I decided to update both in
unwindCallFrame() and when an exception is thrown. I also added some asserts
where I removed updates to topCallFrame just to make sure that the callframes
at those points were correct. This patch has also been modified to work with
arm processors. Hopefully I didn't miss anything


More information about the webkit-reviews mailing list