[webkit-reviews] review denied: [Bug 49080] webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation : [Attachment 104868] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 49080: webkit-perl tests fail on win32 Perl due to lack of list form of
pipe open implementation
https://bugs.webkit.org/show_bug.cgi?id=49080

Attachment 104868: Patch
https://bugs.webkit.org/attachment.cgi?id=104868&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104868&action=review


> Tools/Scripts/VCSUtils.pm:1699
> -	   open(DIFF, "-|", qw(diff -u -a --binary), $fileOlder, $fileMine) or
die $!;
> +	   open(DIFF, "diff -u -a --binary $fileOlder $fileMine |") or die $!;

You now need to quote $fileOlder and $fileMine in case they contain spaces.