[webkit-reviews] review denied: [Bug 66710] Assertion fires if canvas is resized while save() active : [Attachment 104853] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 66710: Assertion fires if canvas is resized while save() active
https://bugs.webkit.org/show_bug.cgi?id=66710

Attachment 104853: Patch
https://bugs.webkit.org/attachment.cgi?id=104853&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104853&action=review


> Source/WebCore/html/HTMLCanvasElement.cpp:328
> +#if !ASSERT_DISABLED
> +    if (m_context)
> +	   m_context->clearStateStack();
> +#endif

I don't think state stack behavior should change between debug and non-debug
builds. This could lead to hard-to-find bugs.