[webkit-reviews] review denied: [Bug 66223] [Qt] inspector/debugger/open-close-open.html fails on Qt port : [Attachment 104474] fix

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 66223: [Qt] inspector/debugger/open-close-open.html fails on Qt port
https://bugs.webkit.org/show_bug.cgi?id=66223

Attachment 104474: fix
https://bugs.webkit.org/attachment.cgi?id=104474&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104474&action=review


> LayoutTests/http/tests/inspector/inspector-test.js:376
> +	   setTimeout(function() { callback(); }, 0);

layoutTestController.closeWebInspector -> InspectorController::close ->
InspectorFrontend::disconnectFromBackend ->
setTimeout(WebInspector.disconnectFromBackend) ->
InspectorFrontendHost.disconnectFromBackend -> closing the inspector.

This does prove that callback is called before inspector is closed, but this is
somehow not critical for the rest of the ports sharing the logic. What is the
failure symptoms? Could it be difference in the DRT implementation? (DRT should
be closing inspector after each test synchronously).