[webkit-reviews] review granted: [Bug 66767] Web Inspector: [Extensions API] provide access to page resources : [Attachment 104846] patch (normalize test output)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 08:25:11 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 66767: Web Inspector: [Extensions API] provide access to page resources
https://bugs.webkit.org/show_bug.cgi?id=66767

Attachment 104846: patch (normalize test output)
https://bugs.webkit.org/attachment.cgi?id=104846&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104846&action=review


> Source/WebCore/inspector/front-end/ExtensionAPI.js:522
> +	       interface.__defineGetter__(member, bind(descriptor.get,
implementation));

This won't compile. Could you please avoid using __defineGetter?


More information about the webkit-reviews mailing list