[webkit-reviews] review granted: [Bug 66523] [chromium] RenderView should register for WebGraphics3D callbacks : [Attachment 104518] Address Nat's comments

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Iain Merrick
<husky at google.com>'s request for review:
Bug 66523: [chromium] RenderView should register for WebGraphics3D callbacks
https://bugs.webkit.org/show_bug.cgi?id=66523

Attachment 104518: Address Nat's comments
https://bugs.webkit.org/attachment.cgi?id=104518&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104518&action=review


Seems reasonable.  Where's the chromium side?

Given how many callbacks we have now (lost context, swapbuffers complete,
swapbuffers posted, etc etc) I wonder if it's time to move to a more general
interface for this sort of thing.

> WebKit/chromium/ChangeLog:18
> +	   * public/WebGraphicsContext3D.h:
> +	  
(WebKit::WebGraphicsContext3D::WebGraphicsSwapBuffersPostedCallbackCHROMIUM::~W
ebGraphicsSwapBuffersPostedCallbackCHROMIUM):
> +	  
(WebKit::WebGraphicsContext3D::setSwapBuffersPostedCallbackCHROMIUM):
> +	   * public/WebViewClient.h:
> +	   (WebKit::WebViewClient::initCompositorContext):
> +	   * src/WebViewImpl.cpp:
> +	   (WebKit::WebViewImpl::createLayerTreeHostContext3D):
> +	   (WebKit::WebViewImpl::graphicsContext3D):

This is out of date, please regenerate (or just edit).