[webkit-reviews] review granted: [Bug 66700] [EFL] Add auxiliary history functions for DRT : [Attachment 104714] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 22 18:41:04 PDT 2011
Kent Tamura <tkent at chromium.org> has granted Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 66700: [EFL] Add auxiliary history functions for DRT
https://bugs.webkit.org/show_bug.cgi?id=66700
Attachment 104714: Patch
https://bugs.webkit.org/attachment.cgi?id=104714&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104714&action=review
> Source/WebKit/efl/ewk/ewk_history.cpp:413
> + * Returns a newly-allocated string with the item's target name.
Probably you had better provide information about
- Callers should delete the allocated string
- how to delete the allocated string
because the users can't know the function is using strdup() without reading the
source code.
More information about the webkit-reviews
mailing list