[webkit-reviews] review granted: [Bug 66721] Attempt to clean up bidiNext usage : [Attachment 104750] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 66721: Attempt to clean up bidiNext usage
https://bugs.webkit.org/show_bug.cgi?id=66721

Attachment 104750: Patch
https://bugs.webkit.org/attachment.cgi?id=104750&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104750&action=review


r=me. looks sane to me.

> Source/WebCore/ChangeLog:24
> +	   In reviewing this code be aware that the previous bidiNext default
was to "skip empty inlines" (skipInlines = true).
> +	   Thus any caller who didn't pass true/false should now be calling
bidiNextSkippingEmptyInlines instead.

These two lines appear to be much longer than the lines above.