[webkit-reviews] review granted: [Bug 66722] Move code from PageClientImpl::doneWithKeyEvent to WKView : [Attachment 104744] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 66722: Move code from PageClientImpl::doneWithKeyEvent to WKView
https://bugs.webkit.org/show_bug.cgi?id=66722

Attachment 104744: Patch
https://bugs.webkit.org/attachment.cgi?id=104744&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104744&action=review


> Source/WebKit2/UIProcess/API/mac/WKView.mm:2060
> +- (void)_doneWithKeyEvent:(const WebKit::NativeWebKeyboardEvent&)event
wasEventHandled:(BOOL)wasEventHandled

Objective-C methods that take C++ type arguments end up with super-long
selectors. Probably no clean way of avoiding that in this case.

I think the second half of the selection should be eventWasHandled instead of
wasEventHandled.