[webkit-reviews] review granted: [Bug 66433] [chromium] Remove LayerRendererChromium references from TiledLayerChromium : [Attachment 104721] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 66433: [chromium] Remove LayerRendererChromium references from
TiledLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=66433

Attachment 104721: Patch
https://bugs.webkit.org/attachment.cgi?id=104721&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104721&action=review


Looks like a step in the right direction.

For max texture size it makes sense to grab that information during
initialization and stash it. To be truly exhaustive, we should be refetching
this on every lost context, since the new context could have a different limit
(if the user changed their gfx driver on win7, or they switched to some other
output device or whatever).  For mapSub support and bestTextureFormat, we
shouldn't need that until upload time so I wonder if we can do something
fancier.  No great harm in stashing it for now, though.

> Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.h:55
> +    LayerTextureUpdaterCanvas(PassOwnPtr<LayerPainterChromium>);

harro one-arg constructor~~~~~~