[webkit-reviews] review denied: [Bug 53438] Text-overflow is broken for button elements : [Attachment 104741] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 53438: Text-overflow is broken for button elements
https://bugs.webkit.org/show_bug.cgi?id=53438

Attachment 104741: Patch
https://bugs.webkit.org/attachment.cgi?id=104741&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104741&action=review


r-

> Source/WebCore/rendering/RenderBox.h:346
> +    virtual bool hasControlClip() const { return parentBox() &&
parentBox()->hasControlClip() && isAnonymousBlock(); }

I'd move isAnonymousBlock to be the first condition in the return statement
instead of the last.

> Source/WebCore/rendering/RenderBox.h:347
> +    virtual LayoutRect controlClipRect(const IntPoint&) const;

Don't change the interface here. Should still be layoutpoint.