[webkit-reviews] review requested: [Bug 66666] CSS: Implement 'font' property in CSSComputedStyle. : [Attachment 104738] Proposed patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 22 14:30:41 PDT 2011


Andreas Kling <kling at webkit.org> has asked  for review:
Bug 66666: CSS: Implement 'font' property in CSSComputedStyle.
https://bugs.webkit.org/show_bug.cgi?id=66666

Attachment 104738: Proposed patch v3
https://bugs.webkit.org/attachment.cgi?id=104738&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Factored the CSSPropertyFont* code out of getPropertyCSSValue() to guarantee
consistent return types.
CSSPropertyFontFamily will now always yield a CSSValueList, where it would
previously return a CSSPrimitiveValue when there was only a single family.
They serialize just the same, and the storage overhead for a
Vector<RefPtr<CSSValue>> (and a bool) seems negligible.


More information about the webkit-reviews mailing list