[webkit-reviews] review denied: [Bug 47148] CSS 2.1 failure: abspos-non-replaced-width-margin-000, abspos-replaced-width-margin-000 : [Attachment 103651] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 47148: CSS 2.1 failure: abspos-non-replaced-width-margin-000,
abspos-replaced-width-margin-000
https://bugs.webkit.org/show_bug.cgi?id=47148

Attachment 103651: Patch
https://bugs.webkit.org/attachment.cgi?id=103651&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103651&action=review


I guess I'll trust the quirks mode elimination, but why remove the strict mode
test case? Is it actually wrong?

> Source/WebCore/rendering/RenderBox.cpp:2193
> -	   int staticPosition = child->layer()->staticInlinePosition() +
containerLogicalWidth + containerBlock->borderLogicalRight();
> +	   int staticPosition = enclosingBox->borderAndPaddingStart() +
containerLogicalWidth + containerBlock->borderLogicalLeft();

I do not understand this change. Using left borders when the offset is designed
to be from the right edge does not make any sense to me.