[webkit-reviews] review canceled: [Bug 66340] REGRESSION (r89086): All worker xhr requests trigger preflight requests. : [Attachment 104552] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has canceled David Levin
<levin at chromium.org>'s request for review:
Bug 66340: REGRESSION (r89086): All worker xhr requests trigger preflight
requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Attachment 104552: Patch
https://bugs.webkit.org/attachment.cgi?id=104552&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Despite what I said in comment 1, I'm not sure if it's the best approach to
move
> headers that are special cased in XMLHttpRequest to some shared location.
It's
> ThreadableLoader client (in this case, XHR) who really knows if JavaScript
code
> called one of those methods that added non-engine headers. Many other clients

> simply don't provide any way to specify custom headers, so doing checks on
these
> is pointless.

> What do you think?

It seemed reasonable to move these checks over here as you suggested
previously. I suspect the added cost is negligible and this doesn't seem like a
performance sensitive path.

However, I don't really care to have all of this moved over and mostly did it
due to the suggestion :).

So I'll withdraw this patch and do one with only the test code which should
help us catch any future regressions.