[webkit-reviews] review denied: [Bug 66683] Use monotonic clock for requestAnimationFrame's time parameter : [Attachment 104695] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Nat Duca <nduca at chromium.org>'s
request for review:
Bug 66683: Use monotonic clock for requestAnimationFrame's time parameter
https://bugs.webkit.org/show_bug.cgi?id=66683

Attachment 104695: Patch
https://bugs.webkit.org/attachment.cgi?id=104695&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104695&action=review


R- for lack of timebase.

I'll start up the standards discussion on public-web-perf@ about these changes.


> Source/WebCore/ChangeLog:8
> +	   https://bugs.webkit.org/show_bug.cgi?id=66683
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * dom/Document.cpp:

need some words here - explain what's changing.  In particular, highlight that
the type of the parameter is changing as well

> Source/WebKit/chromium/src/WebViewImpl.cpp:1058
> +	   frameBeginTime = webKitClient()->monotonicallyIncreasingTime();

this doesn't have the right timebase - we need to set the zero explicitly
(probably to the root level navigation time).