[webkit-reviews] review denied: [Bug 66506] [chromium] Root layer is not updated when only a portion of tile is updated : [Attachment 104417] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 22 10:51:37 PDT 2011


James Robinson <jamesr at chromium.org> has denied Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 66506: [chromium] Root layer is not updated when only a portion of tile is
updated
https://bugs.webkit.org/show_bug.cgi?id=66506

Attachment 104417: proposed patch
https://bugs.webkit.org/attachment.cgi?id=104417&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
The flush seems fine but I'm not really a fan of making unrelated changes that
don't do anything.  We have not been trying to keep all GL state on the
compositor in any particular state (nor do I think that we would want to), so
restoring some bits of state in an ad-hoc fashion seems to just be adding
complexity for no benefit.  If we do need a given GL state to be maintained on
the compositor context then we should design, test, and be rigorous about it.


More information about the webkit-reviews mailing list