[webkit-reviews] review denied: [Bug 66287] Element without renderer as documentElement triggers NULL ptr : [Attachment 104661] Patch for review
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 22 08:48:13 PDT 2011
Alexey Proskuryakov <ap at webkit.org> has denied review:
Bug 66287: Element without renderer as documentElement triggers NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=66287
Attachment 104661: Patch for review
https://bugs.webkit.org/attachment.cgi?id=104661&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
You should set r? flag, not r+.
This patch needs a regression test. Also, even though Firefox also lets HEAD be
the document element, I'm still not quite sure if this is the way to go. What
does IE do?
More information about the webkit-reviews
mailing list