[webkit-reviews] review granted: [Bug 66299] [Qt] ImageDiff does not consider --tolerance : [Attachment 104035] Patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 66299: [Qt] ImageDiff does not consider --tolerance
https://bugs.webkit.org/show_bug.cgi?id=66299

Attachment 104035: Patch
https://bugs.webkit.org/attachment.cgi?id=104035&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104035&action=review


> Tools/DumpRenderTree/qt/ImageDiff.cpp:128
> +		   if (!difference)
> +		       fprintf(stdout, "diff: %01.2f%% passed\n", 0.0);
> +		   else {

Good catch, thanks for the fix.

- I think (difference==0) would be more talkative.
- Modifying difference to 0.0 is unnecessary. All ports use this copy/paste
code. :)

r=me with these changes.