[webkit-reviews] review requested: [Bug 66557] [Qt] Make QDesktopWebView a QSGItem. : [Attachment 104662] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 22 04:09:29 PDT 2011


Andreas Kling <kling at webkit.org> has asked  for review:
Bug 66557: [Qt] Make QDesktopWebView a QSGItem.
https://bugs.webkit.org/show_bug.cgi?id=66557

Attachment 104662: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=104662&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Updated patch according to comments.
Didn't end up using QSGTexture::convertToNormalizedSourceRect() since that got
more verbose than the old code.
And we now delete the texture in ~QDesktopWebView().


More information about the webkit-reviews mailing list