[webkit-reviews] review granted: [Bug 66635] [Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color. : [Attachment 104631] proposed patch.

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Misha
<Michael.Tyutyunik at nokia.com>'s request for review:
Bug 66635: [Qt] Button text is invisible when mobile theme is in use and
application palette set to use light text color.
https://bugs.webkit.org/show_bug.cgi?id=66635

Attachment 104631: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=104631&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104631&action=review


LGTM. It's a shame we don't test the mobile theme on the bots, though.

> Source/WebCore/ChangeLog:7
> +	   When mobile theme is in use and application pallete is using light 

pallete -> palette

> Source/WebCore/ChangeLog:8
> +	   color to display text button text become invisible. The reason for 

"text button text become" -> "text, button text becomes"

> Source/WebCore/ChangeLog:10
> +	   pallete while when are painting button lightGrayPalette is used.

pallete -> palette
"when are painting button" -> "when we are painting buttons"

> Source/WebCore/ChangeLog:11
> +	   Calling setPaletteFromPageClientIfExists() takes care about the
issue.

about -> of