[webkit-reviews] review denied: [Bug 57632] Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function : [Attachment 87869] [PATCH] Suggested fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 21 12:31:09 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 57632: Web Inspector: appropriateSelectorForNode() invokes the "localName"
getter on DOMNode rather than function
https://bugs.webkit.org/show_bug.cgi?id=57632

Attachment 87869: [PATCH] Suggested fix
https://bugs.webkit.org/attachment.cgi?id=87869&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87869&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:228
> +	   var lowerCaseName = this.localName() ||
node.nodeName().toLowerCase();

Alexander, Yury, this code is not right: "node" is not defined in this context.
Could you please cover this with a test?


More information about the webkit-reviews mailing list