[webkit-reviews] review granted: [Bug 66628] [Qt] QWebSpellChecker plugins crash webkit : [Attachment 104627] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Lindsay Mathieson
<lindsay.mathieson at gmail.com>'s request for review:
Bug 66628: [Qt] QWebSpellChecker plugins crash webkit
https://bugs.webkit.org/show_bug.cgi?id=66628

Attachment 104627: Patch
https://bugs.webkit.org/attachment.cgi?id=104627&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
The patch seems to be the correct fix but the Changelog  is not correctly
formatted.

It should be:

-title
-url

-reviewer line

-description

-changelist with more description if necessary.
----
The description could also be better. Something briefly explaining the bug
e.g.:
"The QtPlatformPlugin was allocated on the stack, so its destructor is
unloading the plugin at the end of the scope.

This patch moves the local creation of QtPlatformPlugin to class member
(TextCheckerClientQt::m_platformPlugin), preventing premature unloading of
plugin."