[webkit-reviews] review denied: [Bug 66571] Keep track of topCallFrame for Stack traces : [Attachment 104538] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 19 12:53:29 PDT 2011


Geoffrey Garen <ggaren at apple.com> has denied Juan C. Montemayor
<jmont at apple.com>'s request for review:
Bug 66571: Keep track of topCallFrame for Stack traces
https://bugs.webkit.org/show_bug.cgi?id=66571

Attachment 104538: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=104538&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104538&action=review


> Source/JavaScriptCore/runtime/JSObject.h:433
>  inline JSObject* asObject(JSValue value)
>  {
> +    if (!value.isCell())
> +	   return 0;
>      return asObject(value.asCell());

This change is no good. No code should call asObject on a value if the value is
not a cell (and therefore not an object). It's akin to a bad C++ cast.

Is this change required to make your patch work?


More information about the webkit-reviews mailing list