[webkit-reviews] review denied: [Bug 66521] TestWebKitAPI breaks on Windows due to fast malloc incompatibility : [Attachment 104531] Recovered gtest unit-tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 19 11:29:04 PDT 2011


David Levin <levin at chromium.org> has denied Dmitry Lomov <dslomov at google.com>'s
request for review:
Bug 66521: TestWebKitAPI breaks on Windows due to fast malloc incompatibility
https://bugs.webkit.org/show_bug.cgi?id=66521

Attachment 104531: Recovered gtest unit-tests
https://bugs.webkit.org/attachment.cgi?id=104531&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Seems fine except it would be good to modify the readme
(http://trac.webkit.org/browser/trunk/Source/ThirdParty/gtest/README.WebKit) to
keep track of the local changes done. It would be good to include info about
the last changes as well.

The purpose is so that when someone wants to pull down a new version of gtest
they can modify it in the same way that we have done locally.


More information about the webkit-reviews mailing list