[webkit-reviews] review granted: [Bug 66502] Switch RenderBlock to to new layout types : [Attachment 104403] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 19 10:57:17 PDT 2011
Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 66502: Switch RenderBlock to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66502
Attachment 104403: Patch
https://bugs.webkit.org/attachment.cgi?id=104403&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104403&action=review
> Source/WebCore/rendering/RenderBlock.cpp:1349
> + repaintRect.intersect(LayoutRect(0, 0, width(), height()));
I'm surprised there isn't a size() function to use here.
> Source/WebCore/rendering/RenderBlock.h:823
> + typedef PODInterval<int, FloatingObject*> FloatingObjectInterval;
> + typedef PODIntervalTree<int, FloatingObject*> FloatingObjectTree;
?
More information about the webkit-reviews
mailing list