[webkit-reviews] review denied: [Bug 66550] [CSSRegions] Test absolute positioning of an element inside a CSS region : [Attachment 104496] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 19 10:10:44 PDT 2011


Tony Chang <tony at chromium.org> has denied Razvan Caliman <rcaliman at adobe.com>'s
request for review:
Bug 66550: [CSSRegions] Test absolute positioning of an element inside a CSS
region
https://bugs.webkit.org/show_bug.cgi?id=66550

Attachment 104496: Patch
https://bugs.webkit.org/attachment.cgi?id=104496&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104496&action=review


> LayoutTests/fast/regions/hit-test-absolute-position.html:42
> +	   var hitElement = document.elementFromPoint(270, 330);

The coordinates of the box seems unreliable because of the text at the top of
the page.  E.g., other platforms may have different font size or spacing
causing the box to be positioned higher or lower.

I would either compute the location of the 'region' div via javascript (you
will find many existing tests that use eventSender.mouse* functions that do
this) or put the text below the region div.


More information about the webkit-reviews mailing list