[webkit-reviews] review denied: [Bug 66361] Pass --makeargs of build-webkit to chromium linux builder : [Attachment 104145] patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 66361: Pass --makeargs of build-webkit to chromium linux builder
https://bugs.webkit.org/show_bug.cgi?id=66361

Attachment 104145: patch
https://bugs.webkit.org/attachment.cgi?id=104145&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104145&action=review


It seems fine to take this patch since many other ports use --makeargs.

> Tools/Scripts/webkitdirs.pm:1834
> +    my $makeArgs = "-j$numCpus";

Nit: We end up add -j$numCpus below so you don't need to set the value here.

> Tools/Scripts/webkitdirs.pm:1839
> +    for my $i (0 .. $#options) {
> +	   if ($options[$i] =~ /^--makeargs=(.*)/i ) {
> +	       $makeArgs = $1;
> +	   }
> +    }

This could be:
for (@options) {
   $makeArgs = $1 if /^--makeargs=(.*)/;
}