[webkit-reviews] review denied: [Bug 66398] add MediaPlayer API for accessing rendered audio stream by the Web Audio API : [Attachment 104252] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Chris Rogers
<crogers at google.com>'s request for review:
Bug 66398: add MediaPlayer API for accessing rendered audio stream by the Web
Audio API
https://bugs.webkit.org/show_bug.cgi?id=66398

Attachment 104252: Patch
https://bugs.webkit.org/attachment.cgi?id=104252&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104252&action=review


Marking r- for now until we figure out the threading and lifetime management
issues.

> Source/WebCore/platform/graphics/MediaPlayer.h:320
> +#if ENABLE(WEB_AUDIO)
> +    AudioSourceProvider* audioSourceProvider();
> +#endif
> +
>  private:

This should be private.

> Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp:63
> +    if (mediaElement() && mediaElement()->player())
> +	   return mediaElement()->player()->audioSourceProvider();
> +

I would rather the audioSourceProvider() function be on HTMLMediaElement so
"player()" isn't necessary here.