[webkit-reviews] review granted: [Bug 66558] Would like to be able to reuse DynamicDeviceScaleFactor's code in other WebKit-agnostic tests : [Attachment 104509] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 66558: Would like to be able to reuse DynamicDeviceScaleFactor's code in
other WebKit-agnostic tests
https://bugs.webkit.org/show_bug.cgi?id=66558

Attachment 104509: Patch
https://bugs.webkit.org/attachment.cgi?id=104509&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104509&action=review


> Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:33
> +class WebKitAgnosticTest : public ::testing::Test {

Please put a comment here explaining what a WebKitAgnosticTest is, I had a hard
time understanding until i saw runWebKit1Test and runWebKit2Test.

> Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:53
> +void WebKitAgnosticTest::loadSynchronously(View view, NSURL *url)

Not sure if this is the best name - it's not really doing a synchronous load.
Maybe loadAndWaitUntilFinished?