[webkit-reviews] review denied: [Bug 66549] [Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to to const ref : [Attachment 104495] change arg to const ref
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 19 06:07:08 PDT 2011
Benjamin Poulain <benjamin at webkit.org> has denied Lars Knudsen
<lars.knudsen at nokia.com>'s request for review:
Bug 66549: [Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to to
const ref
https://bugs.webkit.org/show_bug.cgi?id=66549
Attachment 104495: change arg to const ref
https://bugs.webkit.org/attachment.cgi?id=104495&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104495&action=review
You should use webkit-patch for uploading patches.
I reject for the changelog and educational purpose :)
> Source/WebKit2/ChangeLog:3
> + Changed argument to const ref.
I updated the title, please update the changelog accordingly.
More information about the webkit-reviews
mailing list