[webkit-reviews] review granted: [Bug 66534] Switch RenderBoxModelObject to to new layout types : [Attachment 104456] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 19 00:57:31 PDT 2011
Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 66534: Switch RenderBoxModelObject to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66534
Attachment 104456: Patch
https://bugs.webkit.org/attachment.cgi?id=104456&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104456&action=review
Otherwise looks OK.
> Source/WebCore/rendering/RenderBoxModelObject.cpp:590
> - FloatSize contextScale(static_cast<float>(ctm.xScale()),
static_cast<float>(ctm.yScale()));
> + FloatSize contextScale(static_cast<LayoutUnit>(ctm.xScale()),
static_cast<LayoutUnit>(ctm.yScale()));
LayoutUnit is currently an int, no?
More information about the webkit-reviews
mailing list