[webkit-reviews] review granted: [Bug 66522] Test how HTMLAnchorElement.getParameter reacts to too few arguments : [Attachment 104440] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Pilgrim <pilgrim at chromium.org>'s
request for review:
Bug 66522: Test how HTMLAnchorElement.getParameter reacts to too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66522

Attachment 104440: Patch
https://bugs.webkit.org/attachment.cgi?id=104440&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine. Two comments:

    1) It's probably better to have each test cover more than one function. A
separate test for each function will bulk up the test directory and has few
benefits.

    2) Using a separate script-tests source file is a bit of an anti-pattern.
Alexey Proskuryakov has pointed out that you get almost all the same benefits
if you put the script directly into the HTML file. You can still use the
js-test files.