[webkit-reviews] review granted: [Bug 66265] Move allocation in constructors into separate constructorBody() methods : [Attachment 104419] Fixing windows build errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 18 16:08:14 PDT 2011


Oliver Hunt <oliver at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 66265: Move allocation in constructors into separate constructorBody()
methods
https://bugs.webkit.org/show_bug.cgi?id=66265

Attachment 104419: Fixing windows build errors
https://bugs.webkit.org/attachment.cgi?id=104419&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104419&action=review


> Source/JavaScriptCore/runtime/JSPropertyNameIterator.h:90
> +	       PropertyNameArrayData::PropertyNameVector& propertyNameVector =
propertyNameArrayData->propertyNameVector();

Out of curiosity, how does JSPropertyNameIterator handle gc during
initialisation -- eg. if jsOwnedString triggers a gc?


More information about the webkit-reviews mailing list