[webkit-reviews] review granted: [Bug 66414] Tell media player to prepareToPlay() at end of HTMLMediaElement::load() : [Attachment 104399] load after delay

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Victoria Kirst
<vrk at chromium.org>'s request for review:
Bug 66414: Tell media player to prepareToPlay() at end of
HTMLMediaElement::load()
https://bugs.webkit.org/show_bug.cgi?id=66414

Attachment 104399: load after delay
https://bugs.webkit.org/attachment.cgi?id=104399&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104399&action=review


Marking r+ but please change the test before landing to make sure it will catch
data loading in spite of preload=none.


> LayoutTests/media/video-load-preload-none.html:18
> +	       function load() {

Nit: The opening brace for the function should be on the next line.


> LayoutTests/media/video-load-preload-none.html:20
> +		   run("video.load()");
> +	       }

The test results could be exactly the same if the load is triggered
automatically. You can verify that the load doesn't trigger automatically by
checking readyState and networkState in start() and here.