[webkit-reviews] review granted: [Bug 32509] Composition input method lacks character echo in password input fields : [Attachment 104387] patch 10

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 18 14:34:27 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has granted Chang Shu <cshu at webkit.org>'s
request for review:
Bug 32509: Composition input method lacks character echo in password input
fields
https://bugs.webkit.org/show_bug.cgi?id=32509

Attachment 104387: patch 10
https://bugs.webkit.org/attachment.cgi?id=104387&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104387&action=review


> Source/WebCore/editing/InsertIntoTextNodeCommand.cpp:53
> +    if (m_node->document()->settings() &&
m_node->document()->settings()->passwordEchoEnabled() && m_node->renderer()) {

Is the renderer() check needed, given that we checked rendererIsEditable()
above?

> Source/WebCore/rendering/RenderText.h:120
> +    void secureText(UChar mask);

This shouldn't be public, should it?


More information about the webkit-reviews mailing list