[webkit-reviews] review granted: [Bug 66494] add embedded png checksums to WebKitTestRunner : [Attachment 104385] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 66494: add embedded png checksums to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=66494

Attachment 104385: Patch
https://bugs.webkit.org/attachment.cgi?id=104385&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104385&action=review


> Tools/WebKitTestRunner/CyclicRedundancyCheck.cpp:59
> +    unsigned crc = 0xffffffffL;

I know this is just copied code, but I should point out that this is wrong. If
we want an unsigned constant it should be 0xffffffffU. Adding the "L" prefix
makes it a long, so the type should be "long", not "unsigned".

> Tools/WebKitTestRunner/CyclicRedundancyCheck.cpp:61
> +	   crc = crcTable[(crc ^ buffer[i]) & 0xff] ^ ((crc >> 8) &
0x00ffffffL);

The L is not helpful. A U would be helpful.

> Tools/WebKitTestRunner/CyclicRedundancyCheck.cpp:62
> +    return crc ^ 0xffffffffL;

The L is not helpful. A U would be helpful.