[webkit-reviews] review denied: [Bug 53438] Text-overflow is broken for button elements : [Attachment 104334] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 53438: Text-overflow is broken for button elements
https://bugs.webkit.org/show_bug.cgi?id=53438

Attachment 104334: Patch
https://bugs.webkit.org/attachment.cgi?id=104334&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104334&action=review


r-

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1222
> -    bool hasTextOverflow = style()->textOverflow() && hasOverflowClip();
> +    bool hasTextOverflow = style()->textOverflow();

I think you probably wanted this to be:

bool hasTextOverflow = style()->textOverflow() && (hasOverflowClip() ||
hasControlClip());

It's definitely incorrect to make text overflow apply when overflow is visible.
I suspect this is just a case where the control clip needed to be considered as
well since it's supposed to behave like overflow in this case.