[webkit-reviews] review granted: [Bug 65491] Implement a faster path for painting tables with overflowing cells : [Attachment 103807] New version: taking Dave's comment into account.

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 65491: Implement a faster path for painting tables with overflowing cells
https://bugs.webkit.org/show_bug.cgi?id=65491

Attachment 103807: New version: taking Dave's comment into account.
https://bugs.webkit.org/attachment.cgi?id=103807&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103807&action=review


r=me with one suggested correction.

> Source/WebCore/rendering/RenderTableSection.cpp:1072
> +			   if (m_overflowingCells.contains(current.cells[i]))
> +			       continue;

Just make this part of an or with the other check, so that you don't waste time
checking the overflow hash for non-spanning cells.

if (current.cells[i]->rowSpan() > 1 || current.cells[i]->colSpan() > 1) {
    if (m_overflowingCells.contains(current.cells[i]) ||
spanningCells.contains(current.cells[i]))
	continue;
    spanningCells.add(current.cells[i]);
}