[webkit-reviews] review granted: [Bug 66458] [Refactoring] Add EventDispatchMediator.{h, cpp} and move related classes to that files. : [Attachment 104329] refactoring

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 66458: [Refactoring] Add EventDispatchMediator.{h,cpp} and move related
classes to that files.
https://bugs.webkit.org/show_bug.cgi?id=66458

Attachment 104329: refactoring
https://bugs.webkit.org/attachment.cgi?id=104329&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104329&action=review


> Source/WebCore/WebCore.xcodeproj/project.pbxproj:26192
> +				4AF1AD3E13FD23A400AA9590 /*
EventDispatchMediator.cpp in Sources */,

Please sort this lexicologically.

> Source/WebCore/dom/EventDispatchMediator.h:62
> +inline EventDispatchMediator::EventDispatchMediator()
> +{
> +}

It appears that this can be included in the class declaration.

> Source/WebCore/dom/EventDispatchMediator.h:67
> +inline Event* EventDispatchMediator::event() const
> +{
> +    return m_event.get();
> +}

Ditto.

> Source/WebCore/dom/EventDispatchMediator.h:72
> +inline void EventDispatchMediator::setEvent(PassRefPtr<Event> event)
> +{
> +    m_event = event;
> +}

Ditto.