[webkit-reviews] review granted: [Bug 66224] Web Inspector: extract breakpoint management code to a helper class and add tests. : [Attachment 104324] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 66224: Web Inspector: extract breakpoint management code to a helper class
and add tests.
https://bugs.webkit.org/show_bug.cgi?id=66224

Attachment 104324: Patch
https://bugs.webkit.org/attachment.cgi?id=104324&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104324&action=review


> Source/WebCore/inspector/front-end/BreakpointManager.js:31
> +WebInspector.BreakpointManager = function(debuggerModel, breakpoints,
breakpointAddedDelegate, breakpointRemovedDelegate)

Please remove the breakpoints parameter and replace it with the
"setBreakpointsForTest" method.