[webkit-reviews] review denied: [Bug 66414] Tell media player to prepareToPlay() at end of HTMLMediaElement::load() : [Attachment 104261] layout test polish

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Victoria Kirst
<vrk at chromium.org>'s request for review:
Bug 66414: Tell media player to prepareToPlay() at end of
HTMLMediaElement::load()
https://bugs.webkit.org/show_bug.cgi?id=66414

Attachment 104261: layout test polish
https://bugs.webkit.org/attachment.cgi?id=104261&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104261&action=review


> LayoutTests/media/video-load-preload-none.html:14
> +	       function start()
> +	       {
> +		   findMediaElement();
> +		   video.src = findMediaFile("video", "content/test");
> +
> +		   testExpected("video.preload", "none");
> +		   waitForEventAndEnd('loadedmetadata');
> +		   run("video.load()");
> +	       }

This test can "succeed"  even if preload=none is ignored. While this tests
isn't strictly about that, I think it would be a better test if you add the
event listener and set the src attribute in one function, and call load() after
a delay to you can ensure that the event handler isn't triggered by just
setting the src. We don't like to use setTimeout() in layout tests, but
sometimes it can't really be avoided.