[webkit-reviews] review canceled: [Bug 66286] Use String [] operator instead of indexing into String::characters() directly : [Attachment 104162] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 18 03:40:02 PDT 2011


Xianzhu Wang <wangxianzhu at chromium.org> has canceled Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 66286: Use String [] operator instead of indexing into String::characters()
directly
https://bugs.webkit.org/show_bug.cgi?id=66286

Attachment 104162: updated patch
https://bugs.webkit.org/attachment.cgi?id=104162&action=review

------- Additional Comments from Xianzhu Wang <wangxianzhu at chromium.org>
For now StringIterator is just typedefed to const UChar*. In the future it will
be defined as a class that can handle 8 and 16-bit buffers.
The subject of this bug should be updated, but I'd like to hear your opinions
about the patch and will update the subject if the patch looks good to you.


More information about the webkit-reviews mailing list