[webkit-reviews] review denied: [Bug 37768] Web Inspector: differentiate element highlight colors for margin and padding : [Attachment 104312] [PATCH] Global initializers fix attempt

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 37768: Web Inspector: differentiate element highlight colors for margin and
padding
https://bugs.webkit.org/show_bug.cgi?id=37768

Attachment 104312: [PATCH] Global initializers fix attempt
https://bugs.webkit.org/attachment.cgi?id=104312&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104312&action=review


> Source/WebCore/inspector/DOMNodeHighlighter.cpp:110
> +    DEFINE_STATIC_LOCAL(Color, contentBoxColor, (111, 168, 220, 168));

Defining the {r:,g:,b:,a:} structure and passing it into highlightNode as
highlightNode({marginColor: {}, borderOutlineColor: {}, etc...)
highlightRect({color:, outlineColor})

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:243
> +    if (!fixedFontFamily.isEmpty()) {

Consider extracting method

> Source/WebCore/inspector/front-end/inspector.css:1892
> +    background-color: rgba(246, 178, 107, .66);

You could set these from the JavaScript code (along with the highligthNode
calls).