[webkit-reviews] review denied: [Bug 66224] Web Inspector: extract breakpoint management code to a helper class and add tests. : [Attachment 104028] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 66224: Web Inspector: extract breakpoint management code to a helper class
and add tests.
https://bugs.webkit.org/show_bug.cgi?id=66224

Attachment 104028: Patch
https://bugs.webkit.org/attachment.cgi?id=104028&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104028&action=review


> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:705
> +WebInspector.BreakpointHelper = function(debuggerModel, breakpoints,
breakpointAddedDelegate, breakpointRemovedDelegate)

Class with two inner classes deserves to be defined in a separate file.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:720
> +    registerUISourceCode: function(uiSourceCodeId, rawSourceCode,
persistent)

Can we pass real instance here? Also, remove <persist>.
This could be called uiSourceCodeAdded

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:722
> +	   this._uiSourceCodeInfo[uiSourceCodeId] = { rawSourceCode:
rawSourceCode, persistent: persistent };

This mapping should be bi-directional, should be defined in the RawSourceCode
<-> UISourceCode terms.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:745
> +	   this._uiBreakpoints.addBreakpoint(breakpoint);

Either pass all the parameters into addBreakpoint or define a class for a
breakpoint.