[webkit-reviews] review denied: [Bug 66436] --webkit-visual-word renaming right/leftWordPositionAcrossBoundary : [Attachment 104289] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 17 20:23:31 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has denied Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 66436: --webkit-visual-word renaming right/leftWordPositionAcrossBoundary
https://bugs.webkit.org/show_bug.cgi?id=66436

Attachment 104289: patch
https://bugs.webkit.org/attachment.cgi?id=104289&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104289&action=review


> Source/WebCore/editing/visible_units.cpp:1598
> +static VisiblePosition leftWordPositionIgnoreEditableBoundary(const
VisiblePosition& visiblePosition)

We normally use AcrossEditingBoundary instead of IgnoringEditingBoundary.


More information about the webkit-reviews mailing list